gh-127787: allow to retrieved the clipped slice length in _PyUnicodeError_GetParams
#128980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
reviewed
Jan 20, 2025
encukou
approved these changes
Jan 21, 2025
|
You're welcome! Now I can finally do what I wanted to do in the first place (namely fixing the codecs handlers!!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken the liberty of adding some
assert_*functions just to be always sure that we don't mess up the indices. It's more for the future than for now since the assertions are simple. But I also felt that it'd be nicer to have a function call rather than lots ofassert()one after the other.I also removed some
inlinequalifiers as they are likely no more inlined (since we are calling an inline function with more than 1 or 2 lines more than once in the same function, I think it's better to let the compiler decide on the inlining itself).PyUnicodeErrorinternal C helpers #127787